add chia services group
#19044
Draft
add chia services group
#19044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
altendky
added
Added
github-actions
bot
added
the
merge_conflict
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
github-actions
bot
removed
the
merge_conflict
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose:
we all know that i don't like
if __name__ == "__main__":, running python files directly, having runnable things not included in the command tree ofchia, having to use the daemon to launch services, inconsistent usability of the cli to specify the root path, and... well, maybe that's enough.this eliminates execution of services like
python chia/server/start_full_node.pyorpython -m chia.server.start_full_nodein favor ofchia services full-nodeorpython -m chia services full-node. Since the services are directly executed within the process, rather than launched via the daemon, they are still able to be launched by a debugger as needed or by a service manager like systemd. the entry pointchia_full_nodeis retained (for now...:]).Current Behavior:
New Behavior:
Testing Notes:
Draft For: